Skip to content

Remove + icon from button, change to Add Filter #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2015
Merged

Remove + icon from button, change to Add Filter #7

merged 1 commit into from
May 21, 2015

Conversation

@spadgett
Copy link
Contributor

@spadgett spadgett commented May 20, 2015

Screenshot:

label_selector_and_filter_example

@spadgett
Copy link
Contributor Author

spadgett commented May 20, 2015

@liggitt PTAL. I could also go with just Add.

@liggitt
Copy link
Contributor

liggitt commented May 20, 2015

make setupFilterWidget take an optional opts arg, and do:

opts = opts || {];
var addText = opts.addButtonText || "Add Filter";

The label filter can't assume there's another contextual label telling them it's a filter. In origin, we'll probably change the label to just Add

@spadgett spadgett force-pushed the remove-button-icon branch from de34bcd to 90c35cf Compare May 20, 2015 21:09
@spadgett
Copy link
Contributor Author

spadgett commented May 20, 2015

@liggitt updated with your suggestion

liggitt added a commit that referenced this pull request May 21, 2015
@liggitt
Merge pull request #7 from spadgett/remove-button-icon
8d2f10f 
Remove `+` icon from button, change to `Add Filter`
@liggitt liggitt merged commit 8d2f10f into kubernetes-ui:master May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@spadgett @liggitt